cnauroth commented on code in PR #7980:
URL: https://github.com/apache/hadoop/pull/7980#discussion_r2446383325
##########
hadoop-cloud-storage-project/pom.xml:
##########
@@ -34,6 +34,7 @@
<module>hadoop-cos</module>
<module>hadoop-huaweicloud</module>
<module>hadoop-tos</module>
+ <module>hadoop-cloud-storage-dist</module>
Review Comment:
It seems like we would never need to enter execution of
`hadoop-cloud-storage-dist` unless we are building a distro (activating
`-Pdist`). Should we also wrap inclusion of the sub-module here behind
activation of the `dist` profile?
##########
BUILDING.txt:
##########
@@ -388,6 +388,58 @@ Create a local staging version of the website (in
/tmp/hadoop-site)
Note that the site needs to be built in a second pass after other artifacts.
+----------------------------------------------------------------------------------
+Including Cloud Connector Dependencies in Distributions:
+
+Hadoop distributions include the hadoop modules need to work with data and
services
Review Comment:
Nitpick: "modules needed".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
