[ 
https://issues.apache.org/jira/browse/HADOOP-19605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18031065#comment-18031065
 ] 

ASF GitHub Bot commented on HADOOP-19605:
-----------------------------------------

pan3793 commented on code in PR #7780:
URL: https://github.com/apache/hadoop/pull/7780#discussion_r2443891194


##########
dev-support/docker/vcpkg/vcpkg.json:
##########
@@ -10,7 +10,7 @@
   "overrides": [
     {
       "name": "protobuf",
-      "version": "3.21.12"
+      "version": "3.25.5"

Review Comment:
   @GauthamBanasandra, but it has already been installed `install-protobuf.sh`. 
I think the major advantage of manual installation is to make the protobuf 
version consistent with Java and across all Linux distributions.
   
   Anyway, duplicated installation is not a major issue. Could you please 
review this PR? I tested it in all current Dockerfiles, but my changes in CMake 
files might be dirty (sorry, I'm not familiar with cpp toolchains)





> Upgrade Protobuf 3.25.5 for docker images
> -----------------------------------------
>
>                 Key: HADOOP-19605
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19605
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.4.2
>            Reporter: Cheng Pan
>            Priority: Major
>              Labels: pull-request-available
>
> HADOOP-19289 upgraded protobuf-java 3.25.5, we should use same version for 
> protobuf installed in docker images.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to