[ 
https://issues.apache.org/jira/browse/HADOOP-19726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030393#comment-18030393
 ] 

ASF GitHub Bot commented on HADOOP-19726:
-----------------------------------------

hadoop-yetus commented on PR #8029:
URL: https://github.com/apache/hadoop/pull/8029#issuecomment-3411382684

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 21s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  24m 30s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 19s |  |  trunk passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |   0m 21s |  |  trunk passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  mvnsite  |   0m 21s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  |  trunk passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   0m 20s |  |  trunk passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  shadedclient  |  40m 22s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 14s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 13s |  |  the patch passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |   0m 13s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 14s |  |  the patch passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |   0m 14s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  mvnsite  |   0m 15s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 14s |  |  the patch passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  |  the patch passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  shadedclient  |  14m 55s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 26s | 
[/patch-unit-hadoop-cloud-storage-project_hadoop-tos.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8029/2/artifact/out/patch-unit-hadoop-cloud-storage-project_hadoop-tos.txt)
 |  hadoop-tos in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 19s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  58m 21s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | 
hadoop.fs.tosfs.object.TestObjectMultiRangeInputStream |
   |   | hadoop.fs.tosfs.object.TestObjectRangeInputStream |
   |   | hadoop.fs.tosfs.object.tos.auth.TestEnvironmentCredentialsProvider |
   |   | hadoop.fs.tosfs.object.tos.auth.TestDefaultCredentialsProviderChain |
   |   | hadoop.fs.tosfs.object.TestObjectOutputStream |
   |   | hadoop.fs.tosfs.commit.TestMagicOutputStream |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.51 ServerAPI=1.51 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8029/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8029 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient codespell detsecrets xmllint |
   | uname | Linux 3f25ded462da 5.15.0-153-generic #163-Ubuntu SMP Thu Aug 7 
16:37:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 2bd00ae481cc8a6aeb977fef2700e684236375a4 |
   | Default Java | Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8029/2/testReport/ |
   | Max. process+thread count | 616 (vs. ulimit of 5500) |
   | modules | C: hadoop-cloud-storage-project/hadoop-tos U: 
hadoop-cloud-storage-project/hadoop-tos |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8029/2/console |
   | versions | git=2.25.1 maven=3.9.11 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Add JDK 17 compile options for maven-surefire-plugin in hadoop-tos module
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-19726
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19726
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: hadoop-tos
>    Affects Versions: 3.5.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, the {{hadoop-tos}} module does not have the JDK 17 compile options 
> configured for the {{{}maven-surefire-plugin{}}}, which causes the following 
> error during unit test execution:
> {code:java}
> java.lang.IllegalStateException: Failed to set environment variable   at 
> org.apache.hadoop.fs.tosfs.util.TestUtility.setSystemEnv(TestUtility.java:120)
>        at 
> org.apache.hadoop.fs.tosfs.object.ObjectStorageTestBase.setUp(ObjectStorageTestBase.java:59)
>  at java.base/java.lang.reflect.Method.invoke(Method.java:569)   at 
> java.base/java.util.ArrayList.forEach(ArrayList.java:1511)   at 
> java.base/java.util.ArrayList.forEach(ArrayList.java:1511)Caused by: 
> java.lang.reflect.InaccessibleObjectException: Unable to make field private 
> final java.util.Map java.util.Collections$UnmodifiableMap.m accessible: 
> module java.base does not "opens java.util" to unnamed module @69eee410     
> at 
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
>         at 
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
>         at 
> java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)      
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)      at 
> org.apache.hadoop.fs.tosfs.util.TestUtility.setSystemEnv(TestUtility.java:116)
>        ... 4 more
>  {code}
> This error occurs due to the module system restrictions in JDK 17, where 
> reflection cannot access private fields in the 
> java.util.Collections$UnmodifiableMap class.
>  
> To resolve this issue, JDK 17 compile options have been added to ensure the 
> maven-surefire-plugin works correctly in a JDK 17 environment. This PR adds 
> the necessary compile options for maven-surefire-plugin to support JDK 17, 
> fixing the error and ensuring that unit tests can run smoothly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to