[
https://issues.apache.org/jira/browse/HADOOP-19717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18028047#comment-18028047
]
ASF GitHub Bot commented on HADOOP-19717:
-----------------------------------------
slfan1989 commented on code in PR #8015:
URL: https://github.com/apache/hadoop/pull/8015#discussion_r2410285097
##########
hadoop-cloud-storage-project/hadoop-tos/src/main/java/org/apache/hadoop/fs/tosfs/util/Iterables.java:
##########
@@ -19,7 +19,7 @@
package org.apache.hadoop.fs.tosfs.util;
import org.apache.hadoop.util.Preconditions;
-import org.checkerframework.checker.nullness.qual.Nullable;
+import
org.apache.hadoop.thirdparty.org.checkerframework.checker.nullness.qual.Nullable;
Review Comment:
I think what you said makes some sense, but there are similar users in
AzureBFS as well.
https://github.com/apache/hadoop/blob/1566613c725979d0ccda45822dfa275cbd97467a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsLease.java#L38
@steveloughran I’d like to hear your thoughts — do you think we should
reintroduce a new dependency to resolve the issue where
org.checkerframework.checker.nullness.qual.Nullable cannot be found?
cc: @szetszwo
> Resolve build error caused by missing Checker Framework (NonNull not
> recognized)
> --------------------------------------------------------------------------------
>
> Key: HADOOP-19717
> URL: https://issues.apache.org/jira/browse/HADOOP-19717
> Project: Hadoop Common
> Issue Type: Bug
> Components: hdfs, tos
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> In the recent build, we encountered the following issue:
> *org.checkerframework.checker.nullness.qual.NonNull* could not be recognized,
> and the following error was observed.
> {code:java}
> [ERROR]
> /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8011/ubuntu-focal/src/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:[216,50]
> package org.checkerframework.checker.nullness.qual does not exist
> [ERROR]
> /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8011/ubuntu-focal/src/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:[2509,30]
> cannot find symbol
> [ERROR] symbol: class NonNull
> [ERROR] location: class
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.AsyncThreadFactory
> {code}
> I checked the usage in the related modules, and we should use
> *org.apache.hadoop.thirdparty.org.checkerframework.checker.nullness.qual.NonNull*
> instead of directly using
> {*}org.checkerframework.checker.nullness.qual.NonNull{*}.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
