huangzhaobo99 commented on code in PR #7989:
URL: https://github.com/apache/hadoop/pull/7989#discussion_r2371739527
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java:
##########
@@ -72,14 +72,24 @@ static RenameResult renameToInt(
* Verify quota for rename operation where srcInodes[srcInodes.length-1]
moves
* dstInodes[dstInodes.length-1]
*/
- private static Pair<Optional<QuotaCounts>, Optional<QuotaCounts>>
verifyQuotaForRename(
- FSDirectory fsd, INodesInPath src, INodesInPath dst) throws
QuotaExceededException {
+ private static Triple<Boolean, Optional<QuotaCounts>, Optional<QuotaCounts>>
verifyQuotaForRename(
+ FSDirectory fsd, INodesInPath src, INodesInPath dst, boolean overwrite)
+ throws QuotaExceededException {
Review Comment:
```
/**
* Verify quota for rename operation where srcInodes[srcInodes.length-1]
moves
* dstInodes[dstInodes.length-1]
*
* @param fsd FSDirectory instance
* @param src Source path inodes
* @param dst Destination path inodes
* @param overwrite Whether destination will be overwritten
* @return Triple containing:
* - Boolean: true if quota was updated, false if skipped
* - Optional<QuotaCounts>: Source path quotaCounts delta
* - Optional<QuotaCounts>: Destination path quotaCounts delta
* @throws QuotaExceededException if quota limit is exceeded.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
