ahmarsuhail commented on PR #8007: URL: https://github.com/apache/hadoop/pull/8007#issuecomment-3385655172
@steveloughran this PR address some of your comments on the original IoStats PR. The way the AAL code works currently means it's quite hard to report on a cache hit accurately, so I've skipped that for now. It's something we should report, but will need a bit of a rewrite on our end. I'll see how we can do that. Also quite hard to report on durations (I couldn't think of a way, but it would be nice to do that). We'll need someway so that when the GET request starts, it creates a duration tracker, and then when it finishes, that tracker is closed. but since these callbacks are implemented at a stream level, it doesn't seem possible to track durations for each individual request. any suggestions? Other than that this PR is now ready for another review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
