anujmodi2021 commented on code in PR #7967:
URL: https://github.com/apache/hadoop/pull/7967#discussion_r2382005373
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientHandler.java:
##########
@@ -68,13 +68,13 @@ public AbfsClientHandler(final URL baseUrl,
final SASTokenProvider sasTokenProvider,
final EncryptionContextProvider encryptionContextProvider,
final AbfsClientContext abfsClientContext) throws IOException {
+ initServiceType(abfsConfiguration);
Review Comment:
Why this change?
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -188,7 +189,7 @@ public AbfsBlobClient(final URL baseUrl,
final EncryptionContextProvider encryptionContextProvider,
final AbfsClientContext abfsClientContext) throws IOException {
super(baseUrl, sharedKeyCredentials, abfsConfiguration, tokenProvider,
- encryptionContextProvider, abfsClientContext);
+ encryptionContextProvider, abfsClientContext, AbfsServiceType.BLOB);
Review Comment:
Why this change?
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsApacheHttpClient.java:
##########
@@ -73,18 +80,21 @@ static boolean usable() {
}
AbfsApacheHttpClient(DelegatingSSLSocketFactory delegatingSSLSocketFactory,
- final AbfsConfiguration abfsConfiguration, final KeepAliveCache
keepAliveCache,
- URL baseUrl) {
+ final AbfsConfiguration abfsConfiguration,
+ final KeepAliveCache keepAliveCache,
+ URL baseUrl,
+ final boolean isCacheWarmupNeeded) {
final AbfsConnectionManager connMgr = new AbfsConnectionManager(
createSocketFactoryRegistry(
new SSLConnectionSocketFactory(delegatingSSLSocketFactory,
getDefaultHostnameVerifier())),
new AbfsHttpClientConnectionFactory(), keepAliveCache,
- abfsConfiguration, baseUrl);
+ abfsConfiguration, baseUrl, isCacheWarmupNeeded);
final HttpClientBuilder builder = HttpClients.custom();
builder.setConnectionManager(connMgr)
.setRequestExecutor(
- new
AbfsManagedHttpRequestExecutor(abfsConfiguration.getHttpReadTimeout()))
+ new AbfsManagedHttpRequestExecutor(
Review Comment:
+1
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -254,7 +259,8 @@ private AbfsClient(final URL baseUrl,
abfsApacheHttpClient = new AbfsApacheHttpClient(
DelegatingSSLSocketFactory.getDefaultFactory(),
- abfsConfiguration, keepAliveCache, baseUrl);
+ abfsConfiguration, keepAliveCache, baseUrl,
+ abfsConfiguration.getFsConfiguredServiceType() == abfsServiceType);
Review Comment:
+1
What are we trying to achieve here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
