[
https://issues.apache.org/jira/browse/HADOOP-19282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020365#comment-18020365
]
ASF GitHub Bot commented on HADOOP-19282:
-----------------------------------------
LDVSOFT opened a new pull request, #7966:
URL: https://github.com/apache/hadoop/pull/7966
### Description of PR
`URIBuilder` was used from the AWS SDK for Java v2, to be precise from the
shaded Apache HTTP Client. It is a problem if a user would like not to use the
AWS SDK bundle, since more or less only 3 modules are needed (s3, s3-transfer &
sts), but that may cause problems on unshaded dependency versions. Since a URI
constructor can achieve the same here I switched it as a preferred option.
### How was this patch tested?
I've run [the test
suite](https://hadoop.apache.org/docs/r3.4.1/hadoop-aws/tools/hadoop-aws/testing.html)
against a _eu-west-1_ bucket, without scaling/load since the change shouldn't
affect that. To be exact, with something like this:
<details>
<summary><code class="notranslate">auth-keys.xml</code></summary>
<configuration>
<property>
<name>test.fs.s3a.name</name>
<value>s3a://hadoop-test-‹edited›</value>
</property>
<property>
<name>test.fs.s3a.encryption.enabled</name>
<value>false</value>
<description>Don't wanna</description>
</property>
<property>
<name>test.fs.s3a.create.acl.enabled</name>
<value>false</value>
<description>disabled on server</description>
</property>
<property>
<name>fs.s3a.endpoint.region</name>
<value>eu-west-1</value>
</property>
<property>
<name>fs.s3a.assumed.role.sts.endpoint.region</name>
<value>eu-west-1</value>
</property>
<property>
<name>test.sts.endpoint</name>
<description>Specific endpoint to use for STS requests.</description>
<value>sts.eu-west-1.amazonaws.com</value>
</property>
<property>
<name>fs.s3a.assumed.role.sts.endpoint</name>
<value>${test.sts.endpoint}</value>
</property>
<property>
<name>fs.contract.test.fs.s3a</name>
<value>${test.fs.s3a.name}</value>
</property>
<property>
<!
> S3A: STSClientFactory has hard-coded dependency on shaded HttpClient
> --------------------------------------------------------------------
>
> Key: HADOOP-19282
> URL: https://issues.apache.org/jira/browse/HADOOP-19282
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 3.4.2
> Reporter: melin
> Priority: Major
> Labels: pull-request-available
>
> hadoop-aws directly depends on aws-java-sdk-bundle, and the size of
> aws-java-sdk-bundle is too large.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
