ahmarsuhail commented on code in PR #7882:
URL: https://github.com/apache/hadoop/pull/7882#discussion_r2352378026
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestS3APutIfMatchAndIfNoneMatch.java:
##########
@@ -390,7 +416,7 @@ public void testIfNoneMatchOverwriteWithEmptyFile() throws
Throwable {
// close the stream, should throw RemoteFileChangedException
RemoteFileChangedException exception =
intercept(RemoteFileChangedException.class, stream::close);
- assertS3ExceptionStatusCode(SC_412_PRECONDITION_FAILED, exception);
+ verifyS3ExceptionStatusCode(SC_412_PRECONDITION_FAILED, exception);
Review Comment:
do you know what the difference is with the other tests here?
As in, why with S3 express is it ok to assert that we'll get a 412, whereas
the others tests will throw a 200?
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java:
##########
@@ -203,7 +206,7 @@ protected Configuration createValidRoleConf() throws
JsonProcessingException {
conf.set(ASSUMED_ROLE_SESSION_DURATION, "45m");
// disable create session so there's no need to
// add a role policy for it.
- disableCreateSession(conf);
+ //disableCreateSession(conf);
Review Comment:
nit: can just cut this instead of commenting it out, since we're skipping
these tests if S3 Express is enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
