[
https://issues.apache.org/jira/browse/HADOOP-19660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019837#comment-18019837
]
ASF GitHub Bot commented on HADOOP-19660:
-----------------------------------------
anmolanmol1234 commented on code in PR #7901:
URL: https://github.com/apache/hadoop/pull/7901#discussion_r2344089164
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/WorkloadIdentityTokenProvider.java:
##########
@@ -20,13 +20,13 @@
import java.io.File;
import java.io.IOException;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import org.apache.commons.io.FileUtils;
import org.apache.hadoop.classification.VisibleForTesting;
+import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.thirdparty.com.google.common.base.Strings;
import org.apache.hadoop.util.Preconditions;
+import org.slf4j.Logger;
Review Comment:
Import ordering is incorrect
import java.io.File;
import java.io.IOException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.commons.io.FileUtils;
import org.apache.hadoop.classification.VisibleForTesting;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.thirdparty.com.google.common.base.Strings;
import org.apache.hadoop.util.Preconditions;
> ABFS: Proposed Enhancement in WorkloadIdentityTokenProvider
> -----------------------------------------------------------
>
> Key: HADOOP-19660
> URL: https://issues.apache.org/jira/browse/HADOOP-19660
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.5.0, 3.4.1
> Reporter: Anuj Modi
> Priority: Major
> Labels: pull-request-available
>
> Externally Reported Enhancement:
> *Current Limitation*
> The current WorkloadIdentityTokenProvider implementation works well for
> file-based token scenarios, but it's tightly coupled to file system
> operations and cannot be easily extended for alternative token sources
> {*}Use Case{*}: *Kubernetes TokenRequest API*
> In modern Kubernetes environments, the recommended approach is to use the
> TokenRequest API to generate short-lived, on-demand service account tokens
> rather than relying on projected volume mounts.
> *Proposed Enhancement*
> I propose modifying WorkloadIdentityTokenProvider to accept a Supplier for
> token retrieval instead of being hardcoded to file operations:
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
