[
https://issues.apache.org/jira/browse/HADOOP-19654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020664#comment-18020664
]
ASF GitHub Bot commented on HADOOP-19654:
-----------------------------------------
ahmarsuhail commented on code in PR #7882:
URL: https://github.com/apache/hadoop/pull/7882#discussion_r2352378026
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestS3APutIfMatchAndIfNoneMatch.java:
##########
@@ -390,7 +416,7 @@ public void testIfNoneMatchOverwriteWithEmptyFile() throws
Throwable {
// close the stream, should throw RemoteFileChangedException
RemoteFileChangedException exception =
intercept(RemoteFileChangedException.class, stream::close);
- assertS3ExceptionStatusCode(SC_412_PRECONDITION_FAILED, exception);
+ verifyS3ExceptionStatusCode(SC_412_PRECONDITION_FAILED, exception);
Review Comment:
do you know what the difference is with the other tests here?
As in, why with S3 express is it ok to assert that we'll get a 412, whereas
the others tests will throw a 200?
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java:
##########
@@ -203,7 +206,7 @@ protected Configuration createValidRoleConf() throws
JsonProcessingException {
conf.set(ASSUMED_ROLE_SESSION_DURATION, "45m");
// disable create session so there's no need to
// add a role policy for it.
- disableCreateSession(conf);
+ //disableCreateSession(conf);
Review Comment:
nit: can just cut this instead of commenting it out, since we're skipping
these tests if S3 Express is enabled
> Upgrade AWS SDK to 2.32.x
> -------------------------
>
> Key: HADOOP-19654
> URL: https://issues.apache.org/jira/browse/HADOOP-19654
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, fs/s3
> Affects Versions: 3.5.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> Upgrade to a recent version of 2.32.x while off the critical path of things.
> This is for 3.5.0 only
> HADOOP-19485 froze the sdk at a version which worked with third party stores.
> Apparently the new version works; early tests show that Bulk Delete calls
> with third party stores complain about lack of md5 headers, so some tuning is
> clearly going to be needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
