stoty commented on PR #7955: URL: https://github.com/apache/hadoop/pull/7955#issuecomment-3292078717
> really like this. But you will need to add test cases to verify the exception matching itself works with > > * regexp that doesn't parse That is not relevant as the method already expects a Pattern, not a String. > * null pattern > * no pattern match > * pattern match Add the other tests. However note that the both the existing and new tests for null Exceptions are misleading, as the assertation never fails in that case. Again, IMO those should work the same way for *Includes* and *Matches* , so the current behaviour is at least consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
