slfan1989 commented on code in PR #7922:
URL: https://github.com/apache/hadoop/pull/7922#discussion_r2317288321
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestAvailableSpaceBPPBalanceLocal.java:
##########
@@ -137,8 +137,8 @@ public void testChooseLocalNode() {
.chooseTarget(FILE, 1, localNode,
new ArrayList<DatanodeStorageInfo>(), false, null,
BLOCK_SIZE,
TestBlockStoragePolicy.DEFAULT_STORAGE_POLICY, null);
- Assert.assertEquals(1, targets.length);
- Assert.assertEquals(localNode, targets[0].getDatanodeDescriptor());
+ Assertions.assertEquals(1, targets.length);
Review Comment:
It’s better for us to use static imports.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockInfo.java:
##########
@@ -56,9 +56,9 @@ public void testIsDeleted() {
BlockInfo blockInfo = new BlockInfoContiguous((short) 3);
BlockCollection bc = Mockito.mock(BlockCollection.class);
blockInfo.setBlockCollectionId(1000);
- Assert.assertFalse(blockInfo.isDeleted());
+ Assertions.assertFalse(blockInfo.isDeleted());
Review Comment:
It’s better for us to use static imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
