[
https://issues.apache.org/jira/browse/HADOOP-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017817#comment-18017817
]
ASF GitHub Bot commented on HADOOP-19128:
-----------------------------------------
RocMarshal closed pull request #6680: HADOOP-19128. Unified use of placeholder
for log calling.
URL: https://github.com/apache/hadoop/pull/6680
> Unified use of placeholder for log calling
> ------------------------------------------
>
> Key: HADOOP-19128
> URL: https://issues.apache.org/jira/browse/HADOOP-19128
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: RocMarshal
> Priority: Minor
> Labels: pull-request-available
>
> There're some classes logging with pure string like 'AMLauncher':
> {code:java}
> LOG.info("Setting up container " + masterContainer
> + " for AM " + application.getAppAttemptId()); {code}
> It would be better use as follows?:
> {code:java}
> LOG.info("Setting up container {} for AM {}", masterContainer,
> application.getAppAttemptId()); {code}
>
> If the community decides to do so, I am happy to contribute to it~
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
