[
https://issues.apache.org/jira/browse/HADOOP-19574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017455#comment-18017455
]
ASF GitHub Bot commented on HADOOP-19574:
-----------------------------------------
stoty commented on PR #7892:
URL: https://github.com/apache/hadoop/pull/7892#issuecomment-3242441698
> @stoty , thanks for the update!
>
> > The current HadoopThread (now renamed to SubjectInheritingThread)
intentionally follows the Thread syntax as close as possible for minimum
changes in the callers.
>
> In this patch, we are changing
>
> * `new Thread(..)` -> `new SubjectInheritingThread(..)`
>
> My suggestion is to change
>
> * `new Thread(..)` -> `new SubjectInheritingThread.newBuilder()...build()`
>
> If we do it in separated JIRAs, we will need to rewrite the almost all
code this PR.
Unfortunately, that would only handle less than half of the thread creations.
You cannot override the run() / work() method if you use a factory.
We'd have to convert the run()/work() overrides to Runnables as well, and
that cannot be handled by a simple search and replace.
This patch is huge enough as is.
> Restore Subject propagation semantics for Java 22+
> --------------------------------------------------
>
> Key: HADOOP-19574
> URL: https://issues.apache.org/jira/browse/HADOOP-19574
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Critical
> Labels: pull-request-available
>
> Java 22 breaks Subject propagation for new Threads (when SecurityManager is
> not enabled).
> Previously, the Subject set by Subject.doAs() / Subject.callAs()
> automatically propagated to any new Threads created (via new Thread(), not
> Executors).
> With JDK22, this is no longer the case, new Threads do NOT inherit the
> Subject.
> As Hadoop heavily relies on the original behavior, we somehow need to solve
> this problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
