stoty commented on PR #7892: URL: https://github.com/apache/hadoop/pull/7892#issuecomment-3242441698
> @stoty , thanks for the update! > > > The current HadoopThread (now renamed to SubjectInheritingThread) intentionally follows the Thread syntax as close as possible for minimum changes in the callers. > > In this patch, we are changing > > * `new Thread(..)` -> `new SubjectInheritingThread(..)` > > My suggestion is to change > > * `new Thread(..)` -> `new SubjectInheritingThread.newBuilder()...build()` > > If we do it in separated JIRAs, we will need to rewrite the almost all code this PR. Unfortunately, that would only handle less than half of the thread creations. You cannot override the run() / work() method if you use a factory. We'd have to convert the run()/work() overrides to Runnables as well, and that cannot be handled by a simple search and replace. This patch is huge enough as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
