[
https://issues.apache.org/jira/browse/HADOOP-19658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017362#comment-18017362
]
ASF GitHub Bot commented on HADOOP-19658:
-----------------------------------------
anujmodi2021 commented on code in PR #7914:
URL: https://github.com/apache/hadoop/pull/7914#discussion_r2313015686
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java:
##########
@@ -427,6 +427,8 @@ public static String containerProperty(String property,
String fsName, String ac
public static final String FS_AZURE_BLOB_DIR_DELETE_MAX_THREAD =
"fs.azure.blob.dir.delete.max.thread";
/**Flag to enable/disable sending client transactional ID during
create/rename operations: {@value}*/
public static final String FS_AZURE_ENABLE_CLIENT_TRANSACTION_ID =
"fs.azure.enable.client.transaction.id";
+ /**Flag to enable/disable create idempotency during create operation:
{@value}*/
+ public static final String FS_AZURE_ENABLE_CREATE_IDEMPOTENCY =
"fs.azure.enable.create.idempotency";
Review Comment:
This is only for Blob Idempotency, may be we can keep config name accordingly
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java:
##########
@@ -239,5 +239,7 @@ public final class FileSystemConfigurations {
public static final boolean DEFAULT_FS_AZURE_ENABLE_CLIENT_TRANSACTION_ID =
true;
+ public static final boolean
DEFAULT_FS_AZURE_ENABLE_ENABLE_CREATE_IDEMPOTENCY = true;
Review Comment:
Typo, ENABLE added twice
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsIoUtils.java:
##########
@@ -54,7 +56,15 @@ public static void dumpHeadersToDebugLog(final String origin,
if (key == null) {
key = "HTTP Response";
}
- String values = StringUtils.join(";", entry.getValue());
+ List<String> valuesList = entry.getValue();
Review Comment:
Why this change?
> ABFS: [FNS Over Blob] Support create and rename idempotency on FNS Blob from
> client side
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-19658
> URL: https://issues.apache.org/jira/browse/HADOOP-19658
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: hadoop-azure
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.1
>
>
> Support create and rename idempotency on FNS Blob from client side
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
