[ 
https://issues.apache.org/jira/browse/HADOOP-19667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016568#comment-18016568
 ] 

ASF GitHub Bot commented on HADOOP-19667:
-----------------------------------------

hadoop-yetus commented on PR #7907:
URL: https://github.com/apache/hadoop/pull/7907#issuecomment-3228575609

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |  14m 55s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  40m 25s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 19s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  77m  7s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m  4s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  mvnsite  |   1m  9s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  39m 27s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 39s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 134m 51s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.51 ServerAPI=1.51 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7907/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/7907 |
   | JIRA Issue | HADOOP-19667 |
   | Optional Tests | dupname asflicense mvnsite codespell detsecrets 
markdownlint |
   | uname | Linux 04003553fdc2 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 
19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / ce5422f5a2696efe7d65ae74ebcb3413fe33abde |
   | Max. process+thread count | 667 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7907/1/console |
   | versions | git=2.25.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Clarify legal value constraints for hadoop.security.crypto.buffer.size 
> (min=512; floor to cipher block size)
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-19667
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19667
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.8.5
>            Reporter: AMC-team
>            Priority: Major
>              Labels: pull-request-available
>
> In core-default.xml, the property hadoop.security.crypto.buffer.size is 
> currently documented as “The buffer size used by CryptoInputStream and 
> CryptoOutputStream.” It does not specify the legal value constraints.
> {code:java}
> <property>  
> <name>hadoop.security.crypto.buffer.size</name>  
> <value>8192</value>  
> <description>The buffer size used by CryptoInputStream and 
> CryptoOutputStream.  </description>
> </property> {code}
> The runtime enforces two hidden constraints that are not documented:
> 1. Minimum value is 512 bytes. Values below 512 cause 
> IllegalArgumentException at stream construction time.
> 2. Block-size flooring: The effective buffer size is floored to a multiple of 
> the cipher algorithm’s block size (e.g., 16 bytes for AES/CTR/NoPadding).
> As a result, users may be surprised that:
> 1. Setting a value like 4100 results in an actual capacity of 4096.
> 2. Setting values <512 fails fast with IllegalArgumentException.
> *Expected*
> core-default.xml (and user-facing docs) should explicitly document:
> 1. Minimum legal value: 512 bytes.
> 2. The effective value is floored to the nearest multiple of the cipher 
> algorithm block size (e.g., 16 for AES).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to