stoty commented on PR #7897: URL: https://github.com/apache/hadoop/pull/7897#issuecomment-3226824363
> @stoty > > > The question whether we want to fully support Java 18+ in 3.4.3. > > My current goal is to make Hadoop "client" support Java 18+ in the next 3.4.x. version, fully Java 18+ support should target 3.5. My problem with that is that I am not at all convinced that this patch alone fixes the client fully. The only reliable data point we have is that the Spark tests are running with it. Which parts does Spark even test ? HDFS ? MR/Yarn ? Do Spark tests use secure mode / kerberos ? Do they use doAs/proxyUser ? > > > the large patch for Subject propagation ... > > I roughly understand what you are trying to fix, but I haven't seen real failures caused by this, do you have a concrete example that is affected by the lack of change? and is it must be fixed on Hadoop itself, and can not be workarounded by downstream projects? Just try and run the tests on JDK24/25 without the Thread fixes (i.e current trunk). Many tests will fail without them. Unfortunately I don't have notes on the specific tests, and it was a long enough time ago that I can't remember. > > > * Merge just this patch, and release in 3.4.3 - This seems to be enough for at least the Spark tests to pass > > I won't block 3.4.2 release if it's already in good shape, I prefer this option. I agree with not delaying 3.4.2 further, but have reservations about only adding this patch in 3.4.3, as noted above. Going for full JDK25 support in 3.4.3 doesn't block 3.4.2 either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
