MikaelSmith commented on code in PR #7884:
URL: https://github.com/apache/hadoop/pull/7884#discussion_r2291723162
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/SimpleHttpProxyHandler.java:
##########
@@ -107,7 +150,17 @@ public void exceptionCaught(ChannelHandlerContext ctx,
Throwable cause) {
@Override
protected void initChannel(SocketChannel ch) throws Exception {
ChannelPipeline p = ch.pipeline();
- p.addLast(new HttpRequestEncoder(), new Forwarder(uri, client));
+ p.addLast(new HttpRequestEncoder());
+ if (isSecure) {
+ LOG.debug("Proxying secure request {} to {}", uri, host);
+ // Decode the proxy response and - if it's a redirect - rewrite the
+ // Location header to use https instead of http.
+ p.addLast(new HttpResponseDecoder(), new SslRedirectRewriter());
Review Comment:
We haven't done that for HttpResponseDecoder or similar, and
SslRedirectRewriter holds no state. So I agree it would be surprising if that
were needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
