[
https://issues.apache.org/jira/browse/HADOOP-19604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015144#comment-18015144
]
ASF GitHub Bot commented on HADOOP-19604:
-----------------------------------------
anmolanmol1234 commented on code in PR #7853:
URL: https://github.com/apache/hadoop/pull/7853#discussion_r2287958397
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestWasbAbfsCompatibility.java:
##########
@@ -299,32 +311,34 @@ public void testUrlConversion() {
@Test
public void testSetWorkingDirectory() throws Exception {
//create folders
- AzureBlobFileSystem abfs = getFileSystem();
- // test only valid for non-namespace enabled account
- Assume.assumeFalse("Namespace enabled account does not support this test",
- getIsNamespaceEnabled(abfs));
-
- NativeAzureFileSystem wasb = getWasbFileSystem();
-
- Path d1 = path("/d1");
- Path d1d4 = new Path(d1 + "/d2/d3/d4");
- assertMkdirs(abfs, d1d4);
-
- //set working directory to path1
- Path path1 = new Path(d1 + "/d2");
- wasb.setWorkingDirectory(path1);
- abfs.setWorkingDirectory(path1);
- assertEquals(path1, wasb.getWorkingDirectory());
- assertEquals(path1, abfs.getWorkingDirectory());
-
- //set working directory to path2
- Path path2 = new Path("d3/d4");
- wasb.setWorkingDirectory(path2);
- abfs.setWorkingDirectory(path2);
-
- Path path3 = d1d4;
- assertEquals(path3, wasb.getWorkingDirectory());
- assertEquals(path3, abfs.getWorkingDirectory());
+ try (AzureBlobFileSystem abfs = getFileSystem()) {
+ // test only valid for non-namespace enabled account
+ Assume.assumeFalse("Namespace enabled account does not support this
test",
Review Comment:
taken
> ABFS: Fix WASB ABFS compatibility issues
> ----------------------------------------
>
> Key: HADOOP-19604
> URL: https://issues.apache.org/jira/browse/HADOOP-19604
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.1
>
>
> Fix WASB ABFS compatibility issues. Fix issues such as:-
> # BlockId computation to be consistent across clients for PutBlock and
> PutBlockList
> # Restrict url encoding of certain json metadata during setXAttr calls.
> # Maintain the md5 hash of whole block to validate data integrity during
> flush.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
