[
https://issues.apache.org/jira/browse/HADOOP-19343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014789#comment-18014789
]
ASF GitHub Bot commented on HADOOP-19343:
-----------------------------------------
cnauroth commented on code in PR #7877:
URL: https://github.com/apache/hadoop/pull/7877#discussion_r2284051350
##########
hadoop-tools/hadoop-gcp/pom.xml:
##########
@@ -351,7 +351,6 @@
</shadedPattern>
</relocation>
</relocations>
- <shadedArtifactAttached>true</shadedArtifactAttached>
Review Comment:
We have two options:
1. shadedArtifactAttached=true means a separate shaded jar artifact will be
attached to the build. Clients can depend on it by specifying
`<classifier>shaded</classifier>` in the dependency declaration.
2. shadedArtifactAttached=false (the default, hence removed in this patch)
means the shaded jar completely replaces the published artifact. I think this
is what we want for hadoop-gcp, given the tight coupling to specific shaded
versions of things like Guava and gRPC. There wouldn't be much value in the
non-shaded artifacts.
> Add native support for GCS connector
> ------------------------------------
>
> Key: HADOOP-19343
> URL: https://issues.apache.org/jira/browse/HADOOP-19343
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 3.5.0
> Reporter: Abhishek Modi
> Assignee: Arunkumar Chacko
> Priority: Major
> Labels: pull-request-available
> Attachments: GCS connector for Hadoop.pdf, Google Cloud Storage
> connector for Hadoop-1.pdf, Google Cloud Storage connector for Hadoop.pdf,
> Google Cloud Storage connector for Hadoop.v1.pdf, Google Cloud Storage
> connector for Hadoop_v1.pdf
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
