cnauroth commented on code in PR #7869:
URL: https://github.com/apache/hadoop/pull/7869#discussion_r2283352656
##########
hadoop-project/pom.xml:
##########
@@ -108,7 +108,7 @@
<findbugs.version>3.0.5</findbugs.version>
<dnsjava.version>3.6.1</dnsjava.version>
- <guava.version>27.0-jre</guava.version>
+ <guava.version>33.1.0-jre</guava.version>
Review Comment:
Guava is a dependency of the GCS SDK. Without this change, there is a
dependency convergence problem:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (depcheck) on
project hadoop-gcp:
[ERROR] Rule 0:
org.apache.maven.enforcer.rules.dependency.DependencyConvergence failed with
message:
[ERROR] Failed while enforcing releasability.
[ERROR]
[ERROR] Dependency convergence error for
org.codehaus.mojo:animal-sniffer-annotations:jar:1.17 paths to dependency are:
[ERROR] +-org.apache.hadoop:hadoop-gcp:jar:3.5.0-SNAPSHOT
[ERROR] +-com.google.cloud:google-cloud-storage:jar:2.52.0:compile
[ERROR] +-com.google.guava:guava:jar:27.0-jre:compile
[ERROR] +-org.codehaus.mojo:animal-sniffer-annotations:jar:1.17:compile
[ERROR] and
[ERROR] +-org.apache.hadoop:hadoop-gcp:jar:3.5.0-SNAPSHOT
[ERROR] +-com.google.cloud:google-cloud-storage:jar:2.52.0:compile
[ERROR] +-org.codehaus.mojo:animal-sniffer-annotations:jar:1.24:compile
```
However, we don't necessarily need to upgrade it project-wide. I sent up
#7883 to revert this change in hadoop-project/pom.xml and mention the
versioning needs entirely within hadoop-gcp/pom.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
