zeekling commented on code in PR #7855:
URL: https://github.com/apache/hadoop/pull/7855#discussion_r2280804944
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java:
##########
@@ -722,11 +722,10 @@ protected void
autoCorrectContainerAllocation(List<ResourceRequest> resourceRequ
if (allocatedContainers != null) {
for (RMContainer rmContainer : allocatedContainers) {
if (extraContainers > 0) {
- // Change the state of the container from ALLOCATED to EXPIRED
since it is not required.
+ // Change the state of the container from ALLOCATED to RELEASED
+ // since it is not required.
LOG.debug("Removing extra container:{}",
rmContainer.getContainer());
- completedContainer(rmContainer,
SchedulerUtils.createAbnormalContainerStatus(
- rmContainer.getContainerId(),
SchedulerUtils.EXPIRED_CONTAINER),
- RMContainerEventType.EXPIRE);
+ asyncContainerRelease(rmContainer);
Review Comment:
> Yes, the message will be updated from "Container expired since it was
unused" to "Container released by application", which I believe is more
appropriate.
No, I think the old is more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
