[
https://issues.apache.org/jira/browse/HADOOP-19617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013815#comment-18013815
]
ASF GitHub Bot commented on HADOOP-19617:
-----------------------------------------
Copilot commented on code in PR #7871:
URL: https://github.com/apache/hadoop/pull/7871#discussion_r2275019323
##########
hadoop-cloud-storage-project/hadoop-huaweicloud/src/test/java/org/apache/hadoop/fs/obs/TestOBSContractCreate.java:
##########
@@ -35,11 +36,15 @@ protected AbstractFSContract createContract(final
Configuration conf) {
@Override
public void testCreatedFileIsImmediatelyVisible() {
- Assume.assumeTrue("unsupport.", false);
+ assumeThat(false)
+ .as("unsupport.")
+ .isTrue();
}
@Override
public void testCreatedFileIsVisibleOnFlush() {
- Assume.assumeTrue("unsupport", false);
+ assumeThat(false)
+ .as("unsupport.")
Review Comment:
The error message contains a spelling error. 'unsupport' should be
'unsupported' to match standard English.
##########
hadoop-cloud-storage-project/hadoop-huaweicloud/src/test/java/org/apache/hadoop/fs/obs/TestOBSContractRename.java:
##########
@@ -35,11 +36,15 @@ protected AbstractFSContract createContract(final
Configuration conf) {
@Override
public void testRenameFileUnderFileSubdir() {
- Assume.assumeTrue("unsupport.", false);
+ assumeThat(false)
+ .as("unsupport.")
+ .isTrue();
}
@Override
public void testRenameFileUnderFile() {
- Assume.assumeTrue("unsupport.", false);
+ assumeThat(false)
+ .as("unsupport.")
Review Comment:
The error message contains a spelling error. 'unsupport' should be
'unsupported' to match standard English.
##########
hadoop-cloud-storage-project/hadoop-huaweicloud/src/test/java/org/apache/hadoop/fs/obs/TestOBSContractRename.java:
##########
@@ -35,11 +36,15 @@ protected AbstractFSContract createContract(final
Configuration conf) {
@Override
public void testRenameFileUnderFileSubdir() {
- Assume.assumeTrue("unsupport.", false);
+ assumeThat(false)
+ .as("unsupport.")
+ .isTrue();
}
@Override
public void testRenameFileUnderFile() {
- Assume.assumeTrue("unsupport.", false);
+ assumeThat(false)
+ .as("unsupport.")
Review Comment:
The error message contains a spelling error. 'unsupport' should be
'unsupported' to match standard English.
> [JDK17] Remove JUnit4 Dependency
> --------------------------------
>
> Key: HADOOP-19617
> URL: https://issues.apache.org/jira/browse/HADOOP-19617
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Due to the extensive JUnit4 dependencies in the Hadoop modules, we will
> attempt to remove JUnit4 dependencies on a module-by-module basis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
