[
https://issues.apache.org/jira/browse/HADOOP-19649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013650#comment-18013650
]
ASF GitHub Bot commented on HADOOP-19649:
-----------------------------------------
Copilot commented on code in PR #7868:
URL: https://github.com/apache/hadoop/pull/7868#discussion_r2272827582
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAppend.java:
##########
@@ -608,12 +608,12 @@ public void
testCreateExplicitDirectoryOverDfsAppendOverBlob()
**/
@Test
public void testRecreateAppendAndFlush() throws IOException {
+ assumeThat(isAppendBlobEnabled()).as("Not valid for APPEND
BLOB").isFalse();
+ assumeThat(getIngressServiceType()).isEqualTo(AbfsServiceType.BLOB);
Review Comment:
This assumption is placed after the assertThrows() call begins, but should
be before it. The assumption should be checked before setting up the exception
assertion to ensure the test conditions are met first.
```suggestion
assumeThat(getIngressServiceType()).isEqualTo(AbfsServiceType.BLOB);
```
> ABFS: Fixing Test Failures and Wrong assumptions after Junit Upgrade
> --------------------------------------------------------------------
>
> Key: HADOOP-19649
> URL: https://issues.apache.org/jira/browse/HADOOP-19649
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.5.0, 3.4.2
> Reporter: Anuj Modi
> Assignee: Anuj Modi
> Priority: Major
> Labels: pull-request-available
>
> After https://issues.apache.org/jira/browse/HADOOP-19425
> most of the integration tests are getting skipped. All tests need to be fixed
> with this PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
