anujmodi2021 commented on code in PR #7674:
URL: https://github.com/apache/hadoop/pull/7674#discussion_r2272195658
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java:
##########
@@ -569,23 +569,24 @@ protected AbfsOutputStream
createAbfsOutputStreamWithFlushEnabled(
*/
protected long assertAbfsStatistics(AbfsStatistic statistic,
long expectedValue, Map<String, Long> metricMap) {
- assertEquals("Mismatch in " + statistic.getStatName(), expectedValue,
- (long) metricMap.get(statistic.getStatName()));
+ assertEquals(expectedValue, (long) metricMap.get(statistic.getStatName()),
+ "Mismatch in " + statistic.getStatName());
return expectedValue;
}
protected void assumeValidTestConfigPresent(final Configuration conf, final
String key) {
String configuredValue = conf.get(accountProperty(key, accountName),
conf.get(key, ""));
- Assume.assumeTrue(String.format("Missing Required Test Config: %s.", key),
- !configuredValue.isEmpty());
+ assumeThat(configuredValue)
+ .as(String.format("Missing Required Test Config: %s.", key))
+ .isNotEmpty();
}
protected void assumeValidAuthConfigsPresent() {
final AuthType currentAuthType = getAuthType();
- Assume.assumeFalse(
- "SAS Based Authentication Not Allowed For Integration Tests",
- currentAuthType == AuthType.SAS);
+ assumeThat(currentAuthType).
Review Comment:
This is working as assumeTrue but should have been working as assumeFalse.
This is leading to all Integration tests getting skipped.
Will fix this with https://issues.apache.org/jira/browse/HADOOP-19649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
