anmolanmol1234 commented on code in PR #7817:
URL: https://github.com/apache/hadoop/pull/7817#discussion_r2260193538
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/KeepAliveCache.java:
##########
@@ -212,45 +115,34 @@ public synchronized void close() {
@VisibleForTesting
void closeInternal() {
- timerTask.cancel();
- timer.purge();
- while (!empty()) {
- KeepAliveEntry e = pop();
- closeHttpClientConnection(e.httpClientConnection);
+ while (size() != 0) {
+ closeHttpClientConnection(removeFirst());
Review Comment:
Another thread may remove the last element right after your size() check,
causing removeFirst() to throw NoSuchElementException. So better to use
pollFirst() here with null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
