[
https://issues.apache.org/jira/browse/HADOOP-19635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18010313#comment-18010313
]
ASF GitHub Bot commented on HADOOP-19635:
-----------------------------------------
anujmodi2021 commented on code in PR #7825:
URL: https://github.com/apache/hadoop/pull/7825#discussion_r2235533414
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -1160,8 +1160,12 @@ public AbfsRestOperation setPathProperties(final String
path,
// This path could be present as an implicit directory in FNS.
if (op.getResult().getStatusCode() == HTTP_NOT_FOUND &&
isNonEmptyDirectory(path, tracingContext)) {
// Implicit path found, create a marker blob at this path and set
properties.
- this.createPathRestOp(path, false, false, false, null,
- contextEncryptionAdapter, tracingContext);
+ try {
+ this.createPathRestOp(path, false, false, false, null,
+ contextEncryptionAdapter, tracingContext);
+ } catch (AbfsRestOperationException exception) {
+ LOG.debug("Marker creation failed for path {} during
setPathProperties", path);
Review Comment:
+1 on this.
At least status code and storage error code (Enum like PATHNOTFOUND) we
should print in debug log.
Also a comment here on why we are swallowing the error for future reference
will be better.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -1242,7 +1246,12 @@ public AbfsRestOperation getPathStatus(final String path,
&& isImplicitCheckRequired && isNonEmptyDirectory(path,
tracingContext)) {
// Implicit path found.
// Create a marker blob at this path.
- this.createMarkerAtPath(path, null, contextEncryptionAdapter,
tracingContext);
+ try {
+ this.createMarkerAtPath(path, null, contextEncryptionAdapter,
+ tracingContext);
+ } catch (AbfsRestOperationException exception) {
Review Comment:
Was keeping this behind a config not part of the plan?
> ABFS: [FNS Over Blob] Marker creation fail exception should not be propagated
> -----------------------------------------------------------------------------
>
> Key: HADOOP-19635
> URL: https://issues.apache.org/jira/browse/HADOOP-19635
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: hadoop-azure
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.1
>
>
> Marker creation is attempted during certain operations such as {*}create{*},
> {*}getPathStatus{*}, {*}setPathProperties{*}, and {*}rename{*}, in order to
> add a 0-byte file that signifies the existence of a folder at that path.
> However, if marker creation fails, the failure should not be propagated to
> the user.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
