[
https://issues.apache.org/jira/browse/HADOOP-19610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18009905#comment-18009905
]
ASF GitHub Bot commented on HADOOP-19610:
-----------------------------------------
steveloughran commented on PR #7814:
URL: https://github.com/apache/hadoop/pull/7814#issuecomment-3117076931
checkstyles are all about test numbering _100() etc, so invalid
```
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/integration/ITestS3ACommitterMRJob.java:201:
public void test_000() throws Throwable {:15: Name 'test_000' must match
pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/integration/ITestS3ACommitterMRJob.java:206:
public void test_100() throws Throwable {:15: Name 'test_100' must match
pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/integration/ITestS3ACommitterMRJob.java:211:
public void test_200_execute(:15: Name 'test_200_execute' must match pattern
'^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/integration/ITestS3ACommitterMRJob.java:361:
public void test_500() throws Throwable {:15: Name 'test_500' must match
pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/ITestTerasortOnS3A.java:270:
public void test_100_terasort_setup() throws Throwable {:15: Name
'test_100_terasort_setup' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/ITestTerasortOnS3A.java:279:
public void test_110_teragen() throws Throwable {:15: Name 'test_110_teragen'
must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/ITestTerasortOnS3A.java:295:
public void test_120_terasort() throws Throwable {:15: Name
'test_120_terasort' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/ITestTerasortOnS3A.java:312:
public void test_130_teravalidate() throws Throwable {:15: Name
'test_130_teravalidate' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/ITestTerasortOnS3A.java:332:
public void test_140_teracomplete() throws Throwable {:15: Name
'test_140_teracomplete' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/ITestTerasortOnS3A.java:368:
public void test_150_teracleanup() throws Throwable {:15: Name
'test_150_teracleanup' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/terasort/ITestTerasortOnS3A.java:373:
public void test_200_directory_deletion() throws Throwable {:15: Name
'test_200_directory_deletion' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:190:
public void test_010_Reset() throws Throwable {:15: Name 'test_010_Reset'
must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:195:
public void test_020_DeleteThrottling() throws Throwable {:15: Name
'test_020_DeleteThrottling' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[MethodName]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:208:
public void test_030_Sleep() throws Throwable {:15: Name 'test_030_Sleep'
must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName]
```
> S3A: ITests to run under JUnit5
> -------------------------------
>
> Key: HADOOP-19610
> URL: https://issues.apache.org/jira/browse/HADOOP-19610
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 3.5.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> hadoop-aws tests which need to be parameterized on a class level
> are configured to do so through the @ParameterizedClass tag.
> Filesystem contract test suites in hadoop-common have
> also been parameterized as appropriate.
> There are custom JUnit tags declared in org.apache.hadoop.test.tags,
> which add tag strings to test suites/cases declaring them.
> They can be used on the command line and in IDEs to control
> which tests are/are not executed.
> @FlakyTest "flaky"
> @LoadTest "load"
> @RootFilesystemTest "rootfilesystem"
> @ScaleTest "scale"
> For anyone migrating tests to JUnit 5
> * Methods which subclass an existing test case MUST declare the @Test
> tag again -it is no longer inherited.
> * All overridden setup/teardown methods MUST be located and
> @BeforeEach/@AfterEach attribute added respectively
> * Subclasses of a parameterized test suite MUST redeclare themselves
> as a @ParameterizedClass, and the binding mechanism again.
> * Parameterized test suites SHOULD declare a pattern to generate an
> informative parameter value string for logs, IDEs and stack traces, e.g.
> @ParameterizedClass(name="performance-{0}")
> * Test suites SHOULD add a org.apache.hadoop.test.tags tag to
> declare what kind of test it is. These tags are inherited, so it
> may be that only shared superclasses of test suites need to be tagged.
> The abstract filesystem contract tests are NOT declared as integration
> tests -implementations MUST do so if they are integration tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
