ahmarsuhail commented on code in PR #7738:
URL: https://github.com/apache/hadoop/pull/7738#discussion_r2152160614


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AAnalyticsAcceleratorStreamReading.java:
##########
@@ -194,4 +205,61 @@ public void testInvalidConfigurationThrows() throws 
Exception {
         () -> 
S3SeekableInputStreamConfiguration.fromConfiguration(connectorConfiguration));
   }
 
+  /**
+   * This test verifies that the OpenStreamInfo object contains correct 
encryption
+   * settings when reading an SSEC encrypted file with analytics stream.
+   *
+   * @throws Exception
+   */
+
+  @Test
+  public void testAnalyticsStreamOpenStreamInfoWhenSSECEncryptionEnabled() 
throws Exception {

Review Comment:
   this test is messy, I think because a lot of boiler plate that's needed here 
already exists in ITestS3AEncryptionSSEC. 
   
   How about instead of adding the SSE-C test here, add it in 
`ITestS3AEncryptionSSEC`? 
   
   All you have to do there is set AAL to enabled. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to