[
https://issues.apache.org/jira/browse/HADOOP-19558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948712#comment-17948712
]
ASF GitHub Bot commented on HADOOP-19558:
-----------------------------------------
GauthamBanasandra opened a new pull request, #7666:
URL: https://github.com/apache/hadoop/pull/7666
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
* The `AbstractContractAppendTest#testRenameFileBeingAppended()`
tries to rename the file while the handle
to the file is open.
* This isn't allowed on Windows, and thus the
call to rename fails.
* Thus, we need to close the file handle before
attempting to rename it.
### How was this patch tested?
* Verified by running the failing unit test locally
and ensured that it passed.
* Jenkins CI validation for Windows.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Fix testRenameFileBeingAppended on Windows
> ------------------------------------------
>
> Key: HADOOP-19558
> URL: https://issues.apache.org/jira/browse/HADOOP-19558
> Project: Hadoop Common
> Issue Type: Bug
> Components: hadoop-common
> Affects Versions: 3.5.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Critical
> Fix For: 3.5.0
>
>
> The AbstractContractAppendTest#testRenameFileBeingAppended() tries to rename
> the file while the handle is open. This isn't allowed on Windows and thus the
> call to rename fails.
> Thus, we need to close the file handle before attempting to rename it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
