[
https://issues.apache.org/jira/browse/HADOOP-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946042#comment-17946042
]
ASF GitHub Bot commented on HADOOP-19416:
-----------------------------------------
slfan1989 commented on code in PR #7637:
URL: https://github.com/apache/hadoop/pull/7637#discussion_r2051975591
##########
hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKeyAuthorizationKeyProvider.java:
##########
@@ -216,34 +216,34 @@ private static KeyProvider.Options
newOptions(Configuration conf) {
}
- @Test(expected = IllegalArgumentException.class)
+ @Test
public void testDecryptWithKeyVersionNameKeyMismatch() throws Exception {
- final Configuration conf = new Configuration();
- KeyProvider kp =
+ Assertions.assertThrows(IllegalArgumentException.class, () -> {
Review Comment:
Thank you very much for reviewing the code! I have fixed the checkstyle
issue.
> Upgrade JUnit from 4 to 5 in hadoop-kms.
> ----------------------------------------
>
> Key: HADOOP-19416
> URL: https://issues.apache.org/jira/browse/HADOOP-19416
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]