BsoBird commented on code in PR #7602:
URL: https://github.com/apache/hadoop/pull/7602#discussion_r2046211247


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/GlobalStateIdContext.java:
##########
@@ -156,9 +158,18 @@ public long receiveRequestState(RpcRequestHeaderProto 
header,
         ESTIMATED_TRANSACTIONS_PER_SECOND
             * TimeUnit.MILLISECONDS.toSeconds(clientWaitTime)
             * ESTIMATED_SERVER_TIME_MULTIPLIER) {
-      throw new RetriableException(
-          "Observer Node is too far behind: serverStateId = "
-              + serverStateId + " clientStateId = " + clientStateId);
+      if (namesystem.isRetryActive()) {

Review Comment:
   I have a question. Is it necessary for us to keep this configuration item? 
Can we just retry according to ObserverRetryOnActiveException by default and 
then cooperate with a certain number of retries?
   
   like this:
   ```
   int retryTimes = xxx;
   if(retryTimes < max){
   throw new ObserverRetryOnActiveException(message);
   }else{
   throw new RetriableException(message);
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to