[
https://issues.apache.org/jira/browse/HADOOP-19518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944667#comment-17944667
]
ASF GitHub Bot commented on HADOOP-19518:
-----------------------------------------
manika137 commented on code in PR #7564:
URL: https://github.com/apache/hadoop/pull/7564#discussion_r2044172156
##########
hadoop-tools/hadoop-azure/dev-support/testrun-scripts/configsupport.sh:
##########
@@ -106,52 +102,112 @@ obseleteConfigsList=(
"enable.append.support" #fs.azure.enable.append.support
)
+#
------------------------------------------------------------------------------
+# User Interaction
+#
------------------------------------------------------------------------------
+
+promptNamespaceType() {
+ printf "Select 'HNS' if you're migrating to ABFS driver for Hierarchical
Namespace enabled account,
+ or 'Non-HNS' if you're migrating to ABFS driver for
Non-Hierarchical Namespace (FNS) account. \n"
+ printf "WARNING: Please ensure the correct option is chosen as it will
affect the configuration changes made to the file. \n"
+ printf "If you are unsure, follow the instructions below to check from
Azure Portal: \n"
+ printf "* Go to the Azure Portal and navigate to your storage account. \n"
+ printf "* In the left-hand menu, select 'Overview' section and look for
'Properties'. \n"
+ printf "* Under 'Blob service', check if 'Hierarchical namespace' is
enabled or disabled. \n"
+ echo "$contactTeamMsg"
+ select namespaceType in "HNS" "NonHNS"
+ do
+ case $namespaceType in
+ HNS)
+ xmlstarlet ed -L -i '//configuration/property[1]' -t elem -n
property -v '' \
+ -s '//configuration/property[1]' -t elem -n name -v
'fs.azure.account.hns.enabled' \
+ -s '//configuration/property[1]' -t elem -n value -v
'true' "$OUTPUT_FILE"
+ break
+ ;;
+ NonHNS)
+ endpoint=".blob."
+ break
+ ;;
+ *)
+ echo "Invalid selection. Please try again. Exiting..."
+ exit 1
+ ;;
+ esac
+ done
+}
+
+#
------------------------------------------------------------------------------
+# Config File Transformations
+#
------------------------------------------------------------------------------
+
# Stop the script if any unsupported config is found
-for key in "${unsupportedConfigsList[@]}"; do
- if grep -q "$key" "$OUTPUT_FILE"; then
- echo "Remove the following configuration from file and rerun: '$key'"
- failure=true
+unsupportedConfigCheck() {
+ for key in "${unsupportedConfigsList[@]}"; do
+ if grep -q "$key" "$OUTPUT_FILE"; then
+ echo "Remove the following configuration from file and rerun:
'$key'"
+ failure=true
+ fi
+ done
+
+ if [ "$failure" = true ]; then
+ echo "FAILURE: Unsupported Config Found"
Review Comment:
Yes, it's being added from the loop above
> ABFS: [FnsOverBlob] WASB to ABFS Migration Config Support Script
> ----------------------------------------------------------------
>
> Key: HADOOP-19518
> URL: https://issues.apache.org/jira/browse/HADOOP-19518
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0, 3.4.1
> Reporter: Manika Joshi
> Assignee: Manika Joshi
> Priority: Major
> Labels: pull-request-available
>
> The legacy WASB driver has been deprecated and is no longer recommended for
> use. To support customer onboard for migration from WASB to ABFS driver,
> we've introduced a script to help with the configuration changes required for
> the same.
> The script requires the configuration file (in XML format) used for WASB and
> would generate configuration file required for ABFS driver respectively.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
