[
https://issues.apache.org/jira/browse/HADOOP-19525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940886#comment-17940886
]
ASF GitHub Bot commented on HADOOP-19525:
-----------------------------------------
hadoop-yetus commented on PR #7570:
URL: https://github.com/apache/hadoop/pull/7570#issuecomment-2777782249
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 34s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 3s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 54 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 6m 50s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 31m 29s | | trunk passed |
| +1 :green_heart: | compile | 15m 39s | | trunk passed with JDK
Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | compile | 13m 51s | | trunk passed with JDK
Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| +1 :green_heart: | checkstyle | 4m 32s | | trunk passed |
| +1 :green_heart: | mvnsite | 13m 24s | | trunk passed |
| +1 :green_heart: | javadoc | 11m 47s | | trunk passed with JDK
Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javadoc | 11m 7s | | trunk passed with JDK
Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| +1 :green_heart: | spotbugs | 19m 41s | | trunk passed |
| +1 :green_heart: | shadedclient | 34m 47s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 29s | | the patch passed |
| +1 :green_heart: | compile | 14m 59s | | the patch passed with JDK
Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javac | 14m 59s | | the patch passed |
| +1 :green_heart: | compile | 13m 23s | | the patch passed with JDK
Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| +1 :green_heart: | javac | 13m 23s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 4m 27s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7570/5/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 2 new + 2373 unchanged - 28 fixed = 2375 total
(was 2401) |
| +1 :green_heart: | mvnsite | 12m 23s | | the patch passed |
| +1 :green_heart: | javadoc | 11m 12s | | the patch passed with JDK
Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javadoc | 10m 34s | | the patch passed with JDK
Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| +1 :green_heart: | spotbugs | 22m 11s | | the patch passed |
| +1 :green_heart: | shadedclient | 34m 35s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 15m 5s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 6m 16s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 4m 50s | | hadoop-yarn-server-common in
the patch passed. |
| -1 :x: | unit | 148m 42s |
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7570/5/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt)
| hadoop-yarn-server-resourcemanager in the patch passed. |
| +1 :green_heart: | unit | 27m 40s | | hadoop-yarn-server-nodemanager
in the patch passed. |
| +1 :green_heart: | unit | 29m 23s | | hadoop-yarn-client in the patch
passed. |
| +1 :green_heart: | unit | 8m 59s | | hadoop-mapreduce-client-core in
the patch passed. |
| +1 :green_heart: | unit | 9m 15s | | hadoop-mapreduce-client-app in
the patch passed. |
| +1 :green_heart: | unit | 4m 41s | | hadoop-mapreduce-client-hs in
the patch passed. |
| +1 :green_heart: | unit | 130m 14s | |
hadoop-mapreduce-client-jobclient in the patch passed. |
| +1 :green_heart: | unit | 0m 56s | | hadoop-yarn-server-router in
the patch passed. |
| +1 :green_heart: | unit | 22m 37s | |
hadoop-yarn-applications-distributedshell in the patch passed. |
| +1 :green_heart: | unit | 21m 25s | | hadoop-yarn-services-core in
the patch passed. |
| +1 :green_heart: | unit | 12m 58s | | hadoop-sls in the patch passed.
|
| +1 :green_heart: | asflicense | 1m 16s | | The patch does not
generate ASF License warnings. |
| | | 747m 7s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerMultiNodes
|
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7570/5/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/7570 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 08110547face 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18
17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 76b760bd5bf93d44b309a05df449bced6b8e3f44 |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7570/5/testReport/ |
| Max. process+thread count | 1570 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core
hadoop-tools/hadoop-sls U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7570/5/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Use java.time.Clock instead of org.apache.hadoop.util.Clock
> -----------------------------------------------------------
>
> Key: HADOOP-19525
> URL: https://issues.apache.org/jira/browse/HADOOP-19525
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: hadoop-common, mapreduce, yarn
> Reporter: Yaniv Kunda
> Assignee: Yaniv Kunda
> Priority: Major
> Labels: pull-request-available
>
> Hadoop's {{Clock}} interface was recently moved from
> {{org.apache.hadoop.yarn.util}} (in hadoop-yarn) to
> {{org.apache.hadoop.util}} (in hadoop-common) as part of YARN-11765.
> I propose to seize the opportunity of this being targeted done for 3.5.0 to
> modernize it usage:
> # Deprecate {{org.apache.hadoop.util.Clock}}
> # Replace all of its usages with {{java.time.Clock}}
> # Replace existing usages of its simple implementations, e.g.
> {{SystemClock}}/{{UTCClock}} with standard {{java.time.Clock}} subclasses,
> e.g. {{Clock.systemUTC()}}
> # Re-implement other implementations, e.g.
> {{MonotonicClock}}/{{ControllerClock}}, as {{java.time.Clock}} subclasses.
> The standard {{java.time.Clock}} has a richer API supports modern
> {{java.time}} classes such as {{Instant}} and {{ZoneId}}, and migration would
> be straightforward:
> Just changing {{org.apache.hadoop.util.Clock.getTime()}} to
> {{java.time.Clock.millis()}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
