[ 
https://issues.apache.org/jira/browse/HADOOP-19485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940659#comment-17940659
 ] 

ASF GitHub Bot commented on HADOOP-19485:
-----------------------------------------

hadoop-yetus commented on PR #7573:
URL: https://github.com/apache/hadoop/pull/7573#issuecomment-2775467874

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |  11m 42s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 8 new or modified test files.  |
   |||| _ branch-3.4 Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 59s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  33m 22s |  |  branch-3.4 passed  |
   | +1 :green_heart: |  compile  |  16m 33s |  |  branch-3.4 passed with JDK 
Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  compile  |  14m 55s |  |  branch-3.4 passed with JDK 
Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06  |
   | +1 :green_heart: |  checkstyle  |   4m  6s |  |  branch-3.4 passed  |
   | +1 :green_heart: |  mvnsite  |  17m 15s |  |  branch-3.4 passed  |
   | +1 :green_heart: |  javadoc  |   8m 18s |  |  branch-3.4 passed with JDK 
Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 25s |  |  branch-3.4 passed with JDK 
Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06  |
   | +0 :ok: |  spotbugs  |   0m 20s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | -1 :x: |  spotbugs  |  29m 44s | 
[/branch-spotbugs-root-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7573/1/artifact/out/branch-spotbugs-root-warnings.html)
 |  root in branch-3.4 has 1 extant spotbugs warnings.  |
   | +1 :green_heart: |  shadedclient  |  34m 49s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 57s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  30m 38s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 52s |  |  the patch passed with JDK 
Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  javac  |  15m 52s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 10s |  |  the patch passed with JDK 
Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06  |
   | +1 :green_heart: |  javac  |  15m 10s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  7s |  |  root: The patch generated 
0 new + 11 unchanged - 1 fixed = 11 total (was 12)  |
   | +1 :green_heart: |  mvnsite  |  17m 47s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   8m  8s |  |  the patch passed with JDK 
Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 23s |  |  the patch passed with JDK 
Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06  |
   | +0 :ok: |  spotbugs  |   0m 20s |  |  hadoop-project has no data from 
spotbugs  |
   | +1 :green_heart: |  shadedclient  |  61m  5s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 730m 25s |  |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m 51s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 1081m  7s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.48 ServerAPI=1.48 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7573/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/7573 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle 
markdownlint shellcheck shelldocs |
   | uname | Linux 40ab38e987b1 5.15.0-134-generic #145-Ubuntu SMP Wed Feb 12 
20:08:39 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | branch-3.4 / a13da89615fe4e05299a8064c407a0666d476d0d |
   | Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_442-8u442-b06~us1-0ubuntu1~20.04-b06 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7573/1/testReport/ |
   | Max. process+thread count | 4261 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-tools/hadoop-aws . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7573/1/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> S3A: Upgrade AWS V2 SDK to 2.29.52
> ----------------------------------
>
>                 Key: HADOOP-19485
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19485
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build, fs/s3
>    Affects Versions: 3.4.2
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> Upgrade to 2.29.52 -the last version compatible with third party stores until 
> there are fixes in the AWS SDK or workarounds added in the S3A connector
> This SDK update doesn't need to come with some changes to disable some new 
> features (default integrity protections),
> and to apply critical changes related to the SDK
> Default integrity protection came with 2.30, and is on unless disabled.
> https://github.com/aws/aws-sdk-java-v2/issues/5801
> As well as being incompatible with third party stores, it has also affected 
> S3 multiregion Access Points: 
> https://github.com/aws/aws-sdk-java-v2/issues/5878
> This has broken most interaction with third party stores, hence fixes in 
> Iceberg https://github.com/apache/iceberg/pull/12264 and Trinio 
> https://github.com/trinodb/trino/pull/24954
> There's also [AWS v2.30 SDK InputStream behavior changes #5859](AWS v2.30 SDK 
> InputStream behavior changes).
> It looks like our code is safer from that, but it did require code review.
> SDK 2.30.19 seems good with this



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to