[
https://issues.apache.org/jira/browse/HADOOP-19502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938816#comment-17938816
]
ASF GitHub Bot commented on HADOOP-19502:
-----------------------------------------
pan3793 commented on PR #7535:
URL: https://github.com/apache/hadoop/pull/7535#issuecomment-2756918116
So this change intends to add a new checkstyle rule to forbid trailing
spaces of lines, this generally is a good idea, but after I apply it (I change
the severity to error to get the report) and check the current code base, there
are more than 40k places that violate this rule
```
<module name="RegexpSingleline">
<property name="format" value="\s+$"/>
<property name="severity" value="error"/>
</module>
```
```
mvn checkstyle:check | grep RegexpSingleline | wc -l
41890
```
If we add this rule, fixing those warnings will consume much time and
introduce unnecessary commit history, but without real benefits.
Given such a situation, I suggest NOT adding such a rule, and just keeping
things as-is.
> Add RegexpSingleline module to checkstyle.xml
> ---------------------------------------------
>
> Key: HADOOP-19502
> URL: https://issues.apache.org/jira/browse/HADOOP-19502
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.5.0
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Add RegexpSingleline module to checkstyle.xml
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
