[
https://issues.apache.org/jira/browse/HADOOP-19485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933277#comment-17933277
]
ASF GitHub Bot commented on HADOOP-19485:
-----------------------------------------
steveloughran commented on PR #7479:
URL: https://github.com/apache/hadoop/pull/7479#issuecomment-2706163402
Region resolution failures which were not present before. this is _not_ good.
```
[ERROR] Tests run: 21, Failures: 4, Errors: 0, Skipped: 1, Time elapsed:
24.411 s <<< FAILURE! - in org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion
[ERROR] org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.testCentralEndpoint
Time elapsed: 0.912 s <<< FAILURE!
org.opentest4j.AssertionFailedError:
[Endpoint is overridden]
Expecting:
<false>
to be equal to:
<null>
but was not.
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion$RegionInterceptor.beforeExecution(ITestS3AEndpointRegion.java:605)
at
software.amazon.awssdk.core.interceptor.ExecutionInterceptorChain.lambda$beforeExecution$1(ExecutionInterceptorChain.java:59)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at
software.amazon.awssdk.core.interceptor.ExecutionInterceptorChain.beforeExecution(ExecutionInterceptorChain.java:59)
at
software.amazon.awssdk.awscore.internal.AwsExecutionContextBuilder.runInitialInterceptors(AwsExecutionContextBuilder.java:254)
at
software.amazon.awssdk.awscore.internal.AwsExecutionContextBuilder.invokeInterceptorsAndCreateExecutionContext(AwsExecutionContextBuilder.java:144)
at
software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.invokeInterceptorsAndCreateExecutionContext(AwsSyncClientHandler.java:67)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.lambda$execute$1(BaseSyncClientHandler.java:76)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.measureApiCallSuccess(BaseSyncClientHandler.java:182)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.execute(BaseSyncClientHandler.java:74)
at
software.amazon.awssdk.core.client.handler.SdkSyncClientHandler.execute(SdkSyncClientHandler.java:45)
at
software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.execute(AwsSyncClientHandler.java:53)
at
software.amazon.awssdk.services.s3.DefaultS3Client.headBucket(DefaultS3Client.java:6818)
at
software.amazon.awssdk.services.s3.DelegatingS3Client.lambda$headBucket$55(DelegatingS3Client.java:5479)
at
software.amazon.awssdk.services.s3.internal.crossregion.S3CrossRegionSyncClient.invokeOperation(S3CrossRegionSyncClient.java:67)
at
software.amazon.awssdk.services.s3.DelegatingS3Client.headBucket(DelegatingS3Client.java:5479)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.head(ITestS3AEndpointRegion.java:289)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.lambda$expectInterceptorException$1(ITestS3AEndpointRegion.java:280)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:500)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:386)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:455)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.expectInterceptorException(ITestS3AEndpointRegion.java:279)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.testCentralEndpoint(ITestS3AEndpointRegion.java:173)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:750)
[ERROR]
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.testCentralEndpointWithRegion
Time elapsed: 0.771 s <<< FAILURE!
org.opentest4j.AssertionFailedError:
[Endpoint is overridden]
Expecting:
<false>
to be equal to:
<null>
but was not.
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion$RegionInterceptor.beforeExecution(ITestS3AEndpointRegion.java:605)
at
software.amazon.awssdk.core.interceptor.ExecutionInterceptorChain.lambda$beforeExecution$1(ExecutionInterceptorChain.java:59)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at
software.amazon.awssdk.core.interceptor.ExecutionInterceptorChain.beforeExecution(ExecutionInterceptorChain.java:59)
at
software.amazon.awssdk.awscore.internal.AwsExecutionContextBuilder.runInitialInterceptors(AwsExecutionContextBuilder.java:254)
at
software.amazon.awssdk.awscore.internal.AwsExecutionContextBuilder.invokeInterceptorsAndCreateExecutionContext(AwsExecutionContextBuilder.java:144)
at
software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.invokeInterceptorsAndCreateExecutionContext(AwsSyncClientHandler.java:67)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.lambda$execute$1(BaseSyncClientHandler.java:76)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.measureApiCallSuccess(BaseSyncClientHandler.java:182)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.execute(BaseSyncClientHandler.java:74)
at
software.amazon.awssdk.core.client.handler.SdkSyncClientHandler.execute(SdkSyncClientHandler.java:45)
at
software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.execute(AwsSyncClientHandler.java:53)
at
software.amazon.awssdk.services.s3.DefaultS3Client.headBucket(DefaultS3Client.java:6818)
at
software.amazon.awssdk.services.s3.DelegatingS3Client.lambda$headBucket$55(DelegatingS3Client.java:5479)
at
software.amazon.awssdk.services.s3.internal.crossregion.S3CrossRegionSyncClient.invokeOperation(S3CrossRegionSyncClient.java:67)
at
software.amazon.awssdk.services.s3.DelegatingS3Client.headBucket(DelegatingS3Client.java:5479)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.head(ITestS3AEndpointRegion.java:289)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.lambda$expectInterceptorException$1(ITestS3AEndpointRegion.java:280)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:500)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:386)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:455)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.expectInterceptorException(ITestS3AEndpointRegion.java:279)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.testCentralEndpointWithRegion(ITestS3AEndpointRegion.java:189)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:750)
[ERROR] org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.testWithFips Time
elapsed: 0.459 s <<< FAILURE!
org.opentest4j.AssertionFailedError:
[Endpoint is overridden]
Expecting:
<false>
to be equal to:
<null>
but was not.
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion$RegionInterceptor.beforeExecution(ITestS3AEndpointRegion.java:605)
at
software.amazon.awssdk.core.interceptor.ExecutionInterceptorChain.lambda$beforeExecution$1(ExecutionInterceptorChain.java:59)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at
software.amazon.awssdk.core.interceptor.ExecutionInterceptorChain.beforeExecution(ExecutionInterceptorChain.java:59)
at
software.amazon.awssdk.awscore.internal.AwsExecutionContextBuilder.runInitialInterceptors(AwsExecutionContextBuilder.java:254)
at
software.amazon.awssdk.awscore.internal.AwsExecutionContextBuilder.invokeInterceptorsAndCreateExecutionContext(AwsExecutionContextBuilder.java:144)
at
software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.invokeInterceptorsAndCreateExecutionContext(AwsSyncClientHandler.java:67)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.lambda$execute$1(BaseSyncClientHandler.java:76)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.measureApiCallSuccess(BaseSyncClientHandler.java:182)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.execute(BaseSyncClientHandler.java:74)
at
software.amazon.awssdk.core.client.handler.SdkSyncClientHandler.execute(SdkSyncClientHandler.java:45)
at
software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.execute(AwsSyncClientHandler.java:53)
at
software.amazon.awssdk.services.s3.DefaultS3Client.headBucket(DefaultS3Client.java:6818)
at
software.amazon.awssdk.services.s3.DelegatingS3Client.lambda$headBucket$55(DelegatingS3Client.java:5479)
at
software.amazon.awssdk.services.s3.internal.crossregion.S3CrossRegionSyncClient.invokeOperation(S3CrossRegionSyncClient.java:67)
at
software.amazon.awssdk.services.s3.DelegatingS3Client.headBucket(DelegatingS3Client.java:5479)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.head(ITestS3AEndpointRegion.java:289)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.lambda$expectInterceptorException$1(ITestS3AEndpointRegion.java:280)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:500)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:386)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:455)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.expectInterceptorException(ITestS3AEndpointRegion.java:279)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.testWithFips(ITestS3AEndpointRegion.java:224)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:750)
[ERROR] org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.testWithRegionConfig
Time elapsed: 0.468 s <<< FAILURE!
org.opentest4j.AssertionFailedError:
[Endpoint is overridden]
Expecting:
<false>
to be equal to:
<null>
but was not.
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion$RegionInterceptor.beforeExecution(ITestS3AEndpointRegion.java:605)
at
software.amazon.awssdk.core.interceptor.ExecutionInterceptorChain.lambda$beforeExecution$1(ExecutionInterceptorChain.java:59)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at
software.amazon.awssdk.core.interceptor.ExecutionInterceptorChain.beforeExecution(ExecutionInterceptorChain.java:59)
at
software.amazon.awssdk.awscore.internal.AwsExecutionContextBuilder.runInitialInterceptors(AwsExecutionContextBuilder.java:254)
at
software.amazon.awssdk.awscore.internal.AwsExecutionContextBuilder.invokeInterceptorsAndCreateExecutionContext(AwsExecutionContextBuilder.java:144)
at
software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.invokeInterceptorsAndCreateExecutionContext(AwsSyncClientHandler.java:67)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.lambda$execute$1(BaseSyncClientHandler.java:76)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.measureApiCallSuccess(BaseSyncClientHandler.java:182)
at
software.amazon.awssdk.core.internal.handler.BaseSyncClientHandler.execute(BaseSyncClientHandler.java:74)
at
software.amazon.awssdk.core.client.handler.SdkSyncClientHandler.execute(SdkSyncClientHandler.java:45)
at
software.amazon.awssdk.awscore.client.handler.AwsSyncClientHandler.execute(AwsSyncClientHandler.java:53)
at
software.amazon.awssdk.services.s3.DefaultS3Client.headBucket(DefaultS3Client.java:6818)
at
software.amazon.awssdk.services.s3.DelegatingS3Client.lambda$headBucket$55(DelegatingS3Client.java:5479)
at
software.amazon.awssdk.services.s3.internal.crossregion.S3CrossRegionSyncClient.invokeOperation(S3CrossRegionSyncClient.java:67)
at
software.amazon.awssdk.services.s3.DelegatingS3Client.headBucket(DelegatingS3Client.java:5479)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.head(ITestS3AEndpointRegion.java:289)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.lambda$expectInterceptorException$1(ITestS3AEndpointRegion.java:280)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:500)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:386)
at
org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:455)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.expectInterceptorException(ITestS3AEndpointRegion.java:279)
at
org.apache.hadoop.fs.s3a.ITestS3AEndpointRegion.testWithRegionConfig(ITestS3AEndpointRegion.java:215)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:750)
```
> S3A: Upgrade AWS V2 SDK
> -----------------------
>
> Key: HADOOP-19485
> URL: https://issues.apache.org/jira/browse/HADOOP-19485
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, fs/s3
> Affects Versions: 3.4.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> This SDK update doesn't need to come with some changes to disable some new
> features (default integrity protections),
> and to apply critical changes related to the SDK
> Default integrity protection came with 2.30, and is on unless disabled.
> https://github.com/aws/aws-sdk-java-v2/issues/5801
> As well as being incompatible with third party stores, it has also affected
> S3 multiregion Access Points:
> https://github.com/aws/aws-sdk-java-v2/issues/5878
> This has broken most interaction with third party stores, hence fixes in
> Iceberg https://github.com/apache/iceberg/pull/12264 and Trinio
> https://github.com/trinodb/trino/pull/24954
> There's also [AWS v2.30 SDK InputStream behavior changes #5859](AWS v2.30 SDK
> InputStream behavior changes).
> It looks like our code is safer from that, but it did require code review.
> SDK 2.30.19 seems good with this
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
