[
https://issues.apache.org/jira/browse/HADOOP-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272928#comment-13272928
]
Suresh Srinivas commented on HADOOP-8366:
-----------------------------------------
Comments:
# Minor: remove empty lines after int callId = response.getCallId();
# Minor: remove empty line in Server#setupResponse before "if (status ==
RpcStatus.SUCCESS)"
# RpcPayloadHeader.proto
#* Please name RpcStatus to RpcStatusProto. Also it would be nice to delete
unnecessary lines.
#* We should make both callId and status mandatory
#* repsonse_ change to response
Please remember to delete Status.java when you commit the code
+1 for the patch with these changes.
> Use ProtoBuf for RpcResponseHeader
> ----------------------------------
>
> Key: HADOOP-8366
> URL: https://issues.apache.org/jira/browse/HADOOP-8366
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Priority: Blocker
> Attachments: hadoop-8366-1.patch, hadoop-8366-2.patch,
> hadoop-8366-3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
