slfan1989 commented on PR #7440: URL: https://github.com/apache/hadoop/pull/7440#issuecomment-2692624504
> @GauthamBanasandra the CI result shows a lot of test failures, can you check if they are related. The previous ticket [HADOOP-19243](https://issues.apache.org/jira/browse/HADOOP-19243), mentioned JDK-17 as the use case, we should see if this doesn't break that. > > Is there a way to fix the compilation while staying on the same mockito version? > > cc. @slfan1989 / @steveloughran We indeed need to upgrade HADOOP-19243. I have conducted unit tests offline, and without this PR, some unit tests will fail on JDK17. The Mockito version 4.11.0 is not very recent. After upgrading to JUnit5, we should also update the Mockito version. From a personal perspective, I believe downgrading is not a good approach. https://mvnrepository.com/artifact/org.mockito/mockito-core. Can we solve this problem by upgrading the version of the `wro4j-maven-plugin` ? ``` <!-- Asset minifier --> <plugin> <groupId>ro.isdc.wro4j</groupId> <artifactId>wro4j-maven-plugin</artifactId> <version>1.7.9</version> <dependencies> <!-- TODO: Remove this dependency after upgrading wro4j-maven-plugin to 1.8.1 or later. --> <dependency> <groupId>org.mockito</groupId> <artifactId>mockito-inline</artifactId> <version>4.11.0</version> </dependency> </dependencies> .... ``` @GauthamBanasandra Can we try upgrading the version of the `wro4j-maven-plugin`? https://mvnrepository.com/artifact/ro.isdc.wro4j/wro4j-maven-plugin cc: @ayushtkn @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
