anujmodi2021 commented on code in PR #7369:
URL: https://github.com/apache/hadoop/pull/7369#discussion_r1950200295
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/ITestAzureFileSystemErrorConditions.java:
##########
@@ -157,7 +157,7 @@ public void testTransientErrorOnDelete() throws Exception {
// Need to do this test against a live storage account
AzureBlobStorageTestAccount testAccount =
AzureBlobStorageTestAccount.create();
- assumeNotNull(testAccount);
+ assumeTrue(testAccount != null);
Review Comment:
Nit: would it be better to define a accessible method
`assumeNotNull(variable)` that internally calls `assumeTrue(variable!= null);`
This will reduce the overall diffs I feel.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/ITestNativeAzureFileSystemConcurrencyLive.java:
##########
@@ -40,7 +41,7 @@ public class ITestNativeAzureFileSystemConcurrencyLive
extends AbstractWasbTestBase {
private static final int THREAD_COUNT = 102;
- private static final int TEST_EXECUTION_TIMEOUT = 30000;
+ private static final int TEST_EXECUTION_TIMEOUT = 30;
Review Comment:
Why we are reducing this value?? Any specific reason or observation around
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
