[
https://issues.apache.org/jira/browse/HADOOP-19431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925436#comment-17925436
]
ASF GitHub Bot commented on HADOOP-19431:
-----------------------------------------
slfan1989 commented on code in PR #7368:
URL: https://github.com/apache/hadoop/pull/7368#discussion_r1948266968
##########
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java:
##########
@@ -119,6 +119,16 @@ protected SimpleCopyListing(Configuration configuration,
this.randomizeFileListing = randomizeFileListing;
}
+ protected void initSimpleCopyListing(Configuration pConfiguration,
Review Comment:
> Can you please mark this as `VisibleForTesting`?
Thank you for your explanation! I have added the `VisibleForTesting`
annotation above the `initSimpleCopyListing` function.
> Maybe TestCopyListing shouldn't be extending SimpleCopyListing, but no
need to take on further refactoring right now.
This is a great suggestion! I will record it as a to-do. Once we complete
the upgrade from JUnit4 to JUnit5, we will implement this optimization.
> Upgrade JUnit from 4 to 5 in hadoop-distcp.
> -------------------------------------------
>
> Key: HADOOP-19431
> URL: https://issues.apache.org/jira/browse/HADOOP-19431
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
