slfan1989 commented on code in PR #7368:
URL: https://github.com/apache/hadoop/pull/7368#discussion_r1948266968
##########
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/SimpleCopyListing.java:
##########
@@ -119,6 +119,16 @@ protected SimpleCopyListing(Configuration configuration,
this.randomizeFileListing = randomizeFileListing;
}
+ protected void initSimpleCopyListing(Configuration pConfiguration,
Review Comment:
> Can you please mark this as `VisibleForTesting`?
Thank you for your explanation! I have added the `VisibleForTesting`
annotation above the `initSimpleCopyListing` function.
> Maybe TestCopyListing shouldn't be extending SimpleCopyListing, but no
need to take on further refactoring right now.
This is a great suggestion! I will record it as a to-do. Once we complete
the upgrade from JUnit4 to JUnit5, we will implement this optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
