[ 
https://issues.apache.org/jira/browse/HADOOP-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915940#comment-17915940
 ] 

ASF GitHub Bot commented on HADOOP-19331:
-----------------------------------------

hadoop-yetus commented on PR #7300:
URL: https://github.com/apache/hadoop/pull/7300#issuecomment-2606464049

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 18s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 9 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   5m 38s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  18m 41s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 54s |  |  trunk passed with JDK 
Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  compile  |   0m 44s |  |  trunk passed with JDK 
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga  |
   | +1 :green_heart: |  checkstyle  |   0m 30s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 45s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 44s |  |  trunk passed with JDK 
Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   0m 43s |  |  trunk passed with JDK 
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga  |
   | +1 :green_heart: |  spotbugs  |   1m  8s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 30s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   0m 28s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 46s |  |  the patch passed with JDK 
Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04  |
   | +1 :green_heart: |  javac  |   0m 46s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 33s |  |  the patch passed with JDK 
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga  |
   | +1 :green_heart: |  javac  |   0m 33s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  1s | 
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7300/7/artifact/out/blanks-eol.txt)
 |  The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix 
<<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | -0 :warning: |  checkstyle  |   0m 20s | 
[/results-checkstyle-hadoop-tools.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7300/7/artifact/out/results-checkstyle-hadoop-tools.txt)
 |  hadoop-tools: The patch generated 177 new + 3 unchanged - 0 fixed = 180 
total (was 3)  |
   | +1 :green_heart: |  mvnsite  |   0m 28s |  |  the patch passed  |
   | -1 :x: |  javadoc  |   0m 11s | 
[/results-javadoc-javadoc-hadoop-tools_hadoop-aliyun-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7300/7/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-aliyun-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt)
 |  hadoop-tools_hadoop-aliyun-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 
with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 generated 2 new + 0 
unchanged - 0 fixed = 2 total (was 0)  |
   | -1 :x: |  javadoc  |   0m 11s | 
[/results-javadoc-javadoc-hadoop-tools_hadoop-aliyun-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7300/7/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-aliyun-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga.txt)
 |  
hadoop-tools_hadoop-aliyun-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga
 with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga generated 2 
new + 0 unchanged - 0 fixed = 2 total (was 0)  |
   | -1 :x: |  spotbugs  |   0m 26s | 
[/new-spotbugs-hadoop-tools_hadoop-aliyun.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7300/7/artifact/out/new-spotbugs-hadoop-tools_hadoop-aliyun.html)
 |  hadoop-tools/hadoop-aliyun generated 3 new + 0 unchanged - 0 fixed = 3 
total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  21m 23s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 20s |  |  hadoop-aws in the patch passed. 
 |
   | +1 :green_heart: |  unit  |   0m 13s |  |  hadoop-aliyun in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 21s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  80m 12s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | SpotBugs | module:hadoop-tools/hadoop-aliyun |
   |  |  Redundant nullcheck of listResult, which is known to be non-null in 
org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem.innerOssGetFileStatus(Path, 
Set, boolean)  Redundant null check at AliyunOSSFileSystem.java:is known to be 
non-null in 
org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem.innerOssGetFileStatus(Path, 
Set, boolean)  Redundant null check at AliyunOSSFileSystem.java:[line 869] |
   |  |  The method name 
org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystemStore.GenerateOssClient(String,
 CredentialsProvider, ClientConfiguration, Configuration) doesn't start with a 
lower case letter  At AliyunOSSFileSystemStore.java:ClientConfiguration, 
Configuration) doesn't start with a lower case letter  At 
AliyunOSSFileSystemStore.java:[lines 218-223] |
   |  |  org.apache.hadoop.fs.aliyun.oss.OSSFileStatus doesn't override 
org.apache.hadoop.fs.FileStatus.equals(Object)  At OSSFileStatus.java:At 
OSSFileStatus.java:[line 1] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7300/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/7300 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle |
   | uname | Linux f5b9e9f0d7c9 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 
17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 5762829c9bed3a756d271591d4641d4389820124 |
   | Default Java | Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7300/7/testReport/ |
   | Max. process+thread count | 701 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-aws hadoop-tools/hadoop-aliyun U: 
hadoop-tools |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7300/7/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> AliyunOSS :Optimize the process by reducing some extra QPS.
> -----------------------------------------------------------
>
>                 Key: HADOOP-19331
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19331
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/oss
>            Reporter: zhouao
>            Priority: Major
>              Labels: pull-request-available
>
> AliyunOSSConnector has not been updated for a long time. It implements basic 
> functionality,  but its performance is not optimal, especially in terms of 
> QPS requests. It generates a  significant number of invalid QPS, which 
> increases the cost on the storage service side and  also reduces the 
> efficiency on the connector side. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to