[
https://issues.apache.org/jira/browse/HADOOP-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786352#comment-17786352
]
ASF GitHub Bot commented on HADOOP-18956:
-----------------------------------------
fapifta commented on code in PR #6263:
URL: https://github.com/apache/hadoop/pull/6263#discussion_r1394197568
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java:
##########
@@ -297,8 +298,8 @@ public List<HAServiceTarget> getAllOtherNodes() {
@Override
protected boolean isSSLEnabled() {
- return conf.getBoolean(
- DFSConfigKeys.ZK_CLIENT_SSL_ENABLED,
- DFSConfigKeys.DEFAULT_ZK_CLIENT_SSL_ENABLED);
+ return conf.getBoolean(CommonConfigurationKeys.ZK_CLIENT_SSL_ENABLED,
+ conf.getBoolean(DFSConfigKeys.ZK_CLIENT_SSL_ENABLED,
+ DFSConfigKeys.DEFAULT_ZK_CLIENT_SSL_ENABLED));
Review Comment:
The idea is to use the `hadoop.zk.ssl.enabled` as a central configuration
option, if that is set to false or true, then that effectively forces all
Hadoop services to use SSL, while if `hadoop.zk.ssl.enabled` is not set, then
different components can still set it on their own without affecting other
components.
I am not sure I understand what do you mean, as I see Yarn, HDFS and Common
components does this the same way in the patch. Do I miss something? Also if
the idea is bad, or goes against other similar things, I am open to adjust the
behaviour of these configs it just feels straightforward this way.
For the keystore and truststore data I think we need it the other way
around, and we need to use the component specific setting first, and fall back
to the service specific setting.
> Zookeeper SSL/TLS support in ZKDelegationTokenSecretManager and
> ZKSignerSecretProvider
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-18956
> URL: https://issues.apache.org/jira/browse/HADOOP-18956
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Zita Dombi
> Assignee: István Fajth
> Priority: Major
> Labels: pull-request-available
>
> HADOOP-18709 added support for Zookeeper to communicate with SSL/TLS enabled
> in hadoop-common. With those changes we have the necessary parameters, that
> we need to set to enable SSL/TLS in a ZK Client. That change also did changes
> in ZKCuratorManager, so with that it is easy to set the SSL/TLS, for Yarn it
> was done in YARN-11468.
> In DelegationTokenAuthenticationFilter currently we are using
> CuratorFrameworkFactory, it'd be good to change it to use ZKCuratorManager
> and with that we should support SSL/TLS enablement.
> *UPDATE*
> So as I investigated this a bit more, it wouldn't be so easy to move to using
> ZKCuratorManager.
> DelegationTokenAuthenticationFilter uses ZK from two places: in
> ZKDelegationTokenSecretManager and in ZKSignerSecretProvider. In both places
> it uses CuratorFrameworkFactory, but the attributes and creation
> differentiates from ZKCuratorManager.
> In ZKDelegationTokenSecretManager it would be easy to add the new config and
> based on that create ZK with CuratorFrameworkFactory. But
> ZKSignerSecretProvider is in hadoop-auth module and with my change it would
> need hadoop-common, so it would introduce circular dependency between modules
> 'hadoop-auth' and 'hadoop-common'. I'm still working on a straightforward
> solution.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
