[
https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773235#comment-17773235
]
ASF GitHub Bot commented on HADOOP-18889:
-----------------------------------------
ahmarsuhail commented on code in PR #6141:
URL: https://github.com/apache/hadoop/pull/6141#discussion_r1350071549
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABucketExistence.java:
##########
@@ -69,8 +72,14 @@ public void testNoBucketProbing() throws Exception {
assertTrue("getFileStatus on root should always return a directory",
fs.getFileStatus(root).isDirectory());
- expectUnknownStore(
- () -> fs.listStatus(root));
+ try {
Review Comment:
I didn't understand why we're doing this..why will this listStatus call fail
with a third party store?
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestDirectoryMarkerListing.java:
##########
@@ -610,15 +611,18 @@ private void put(final String key, final String content)
throws Exception {
RequestBody.fromString(content)));
}
/**
- * Delete an object.
+ * Delete an object; exceptions are swallowed.
* @param key key
- * @param content string
*/
private void deleteObject(final String key) throws Exception {
- exec("DELETE " + key, () -> {
- s3client.deleteObject(b -> b.bucket(bucket).key(key));
- return "deleted " + key;
- });
+ try {
+ exec("DELETE " + key, () -> {
+ s3client.deleteObject(b -> b.bucket(bucket).key(key));
+ return "deleted " + key;
+ });
+ } catch (IOException ignored) {
Review Comment:
why are we swallowing exceptions here?
> S3A: V2 SDK client does not work with third-party store
> -------------------------------------------------------
>
> Key: HADOOP-18889
> URL: https://issues.apache.org/jira/browse/HADOOP-18889
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Critical
> Labels: pull-request-available
>
> testing against an external store without specifying region now blows up
> because the region is queried off eu-west-1.
> What are we do to here? require the region setting *which wasn't needed
> before? what even region do we provide for third party stores?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
