Hexiaoqiao commented on PR #5925: URL: https://github.com/apache/hadoop/pull/5925#issuecomment-1678411955
> Because the current parameter setting of this method is not optimal Sorry, the core improvement here is that change `isRegularFile(file, true);` to `isRegularFile(file, false);`, right? But I didn't get the performance diff between that. IIUC, both of them need to read file attributions. So why this could improve it, any benchmark result? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
