2005hithlj commented on code in PR #5924:
URL: https://github.com/apache/hadoop/pull/5924#discussion_r1289578811
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java:
##########
@@ -291,9 +291,8 @@ public String toString() {
void reportBadBlocks(ExtendedBlock block,
String storageUuid, StorageType storageType) {
checkBlock(block);
+ ReportBadBlockAction rbbAction = new ReportBadBlockAction(block,
storageUuid, storageType);
Review Comment:
@slfan1989 This improvement may not have much effect, but it does reduce
the creation of redundant and useless temporary objects. At the same time, from
the perspective of code style, the implementation here is not elegant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
