[
https://issues.apache.org/jira/browse/HADOOP-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752283#comment-17752283
]
ASF GitHub Bot commented on HADOOP-18840:
-----------------------------------------
xinglin commented on PR #5926:
URL: https://github.com/apache/hadoop/pull/5926#issuecomment-1670753258
> > @2005hithlj Please check the failed unit test and checkstyle.
>
> @Hexiaoqiao sir. The failed UT 'TestRPCCallBenchmark is not related to my
modification, and it will success in my modification branch in my local env.
>
> And Checkstyle Warn: RpcMetrics.java:122: @Metric("EQueue time")
MutableRate rpcEnQueueTime;:38: Variable 'rpcEnQueueTime' must be private and
have accessor methods. [VisibilityModifier] RpcMetrics.java:123:
MutableQuantiles[] rpcEnQueueTimeQuantiles;:22: Variable
'rpcEnQueueTimeQuantiles' must be private and have accessor methods.
[VisibilityModifier]
>
> If I follow the above prompts to modify, it will break the style of the
RpcMetrics class.
I don't know the unit test but yeah, for the checkstyle, we can ignore these
warnings: for metrics, we don't add visibility modifier. None of the existing
metrics has the visibility modifier.
> Add enQueue time to RpcMetrics
> ------------------------------
>
> Key: HADOOP-18840
> URL: https://issues.apache.org/jira/browse/HADOOP-18840
> Project: Hadoop Common
> Issue Type: Improvement
> Components: rpc-server
> Reporter: Liangjun He
> Assignee: Liangjun He
> Priority: Minor
> Labels: pull-request-available
>
> Sometimes, the request time observed by the client is much longer than the
> queue + process time on the RPC server. Perhaps the RPC request 'waiting
> enQueue' took too long on the RPC server, so we should add enQueue time to
> RpcMetrics.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
